[FFmpeg-devel] [PATCH] lavfi: add xbr filter

[Michael Niedermayer]

On Sun, Oct 26, 2014 at 07:21:41PM +0530, arwa arif wrote:
> The code is running fine on my laptop. What seg-fault log are you getting?

gdb --args ./ffplay_g images.jpeg -vf xbr,xbr
...
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffeb1a6700 (LWP 11984)]
0x00000000004b4105 in d (in=0x7fffd8041840, x1=0, y1=0, x2=0, y2=-1) at libavfilter/vf_xbr.c:45
45          int r2 = *(in->data[0] + y2 * in->linesize[0] + x2*3);
(gdb) bt
#0  0x00000000004b4105 in d (in=0x7fffd8041840, x1=0, y1=0, x2=0, y2=-1) at libavfilter/vf_xbr.c:45
#1  0x00000000004b464c in apply_edge_detection_rules (in=0x7fffd8041840, out=0x7fffd8062180, x=0, y=0) at libavfilter/vf_xbr.c:135
#2  0x00000000004b51c8 in filter_frame (inlink=0x7fffd80347a0, in=0x7fffd8041840) at libavfilter/vf_xbr.c:266
#3  0x00000000004442b0 in ff_filter_frame_framed (link=0x7fffd80347a0, frame=0x7fffd8041840) at libavfilter/avfilter.c:1103
#4  0x0000000000444804 in ff_filter_frame (link=0x7fffd80347a0, frame=0x7fffd8041840) at libavfilter/avfilter.c:1183
#5  0x00000000004b5223 in filter_frame (inlink=0x7fffd8035a20, in=0x0) at libavfilter/vf_xbr.c:272
#6  0x00000000004442b0 in ff_filter_frame_framed (link=0x7fffd8035a20, frame=0x7fffd8062180) at libavfilter/avfilter.c:1103
#7  0x0000000000444804 in ff_filter_frame (link=0x7fffd8035a20, frame=0x7fffd8062180) at libavfilter/avfilter.c:1183
#8  0x00000000004a4b3f in filter_frame (link=0x7fffd8034200, in=0x0) at libavfilter/vf_scale.c:530
#9  0x00000000004442b0 in ff_filter_frame_framed (link=0x7fffd8034200, frame=0x7fffd8041840) at libavfilter/avfilter.c:1103
#10 0x0000000000444804 in ff_filter_frame (link=0x7fffd8034200, frame=0x7fffd8041840) at libavfilter/avfilter.c:1183
#11 0x000000000044b223 in request_frame (link=0x7fffd8034200) at libavfilter/buffersrc.c:499
#12 0x000000000044216b in ff_request_frame (link=0x7fffd8034200) at libavfilter/avfilter.c:351
#13 0x0000000000442199 in ff_request_frame (link=0x7fffd8035a20) at libavfilter/avfilter.c:353
#14 0x0000000000442199 in ff_request_frame (link=0x7fffd80347a0) at libavfilter/avfilter.c:353
#15 0x0000000000442199 in ff_request_frame (link=0x7fffd80349a0) at libavfilter/avfilter.c:353
#16 0x0000000000442199 in ff_request_frame (link=0x7fffd8033f40) at libavfilter/avfilter.c:353
#17 0x0000000000442199 in ff_request_frame (link=0x7fffd8035d20) at libavfilter/avfilter.c:353
#18 0x0000000000448f5e in av_buffersink_get_frame_flags (ctx=0x7fffd80339e0, frame=0x7fffd80008c0, flags=0) at libavfilter/buffersink.c:137
#19 0x000000000041f566 in video_thread (arg=0x7fffeb1a7040) at ffplay.c:2168
#20 0x00007ffff64a6fd5 in ?? () from /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0
#21 0x00007ffff64ea999 in ?? () from /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0
#22 0x00007ffff006ae9a in start_thread (arg=0x7fffeb1a6700) at pthread_create.c:308
#23 0x00007fffefd9831d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:112
#24 0x0000000000000000 in ?? ()


> 
> Also, I looked on internet for converting rgb to yuv with integers, I got
> these equations.
> http://stackoverflow.com/questions/4979504/fast-rgb-yuv-conversion-in-opencl

well, the code needs to do what the "reference" xbr does, and with
intergers instead of floats, theres no need to get this 100% bitexact
but it should be within +-1 on the integer output
copying some rgb-yuv code of the net, in this case does something else
it seems

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141026/1aa2e4c0/attachment.asc>