[FFmpeg-devel] [Binathi/ffmpeg] d83ead: Forks new process to allow ffserver run in daemon ...

Nicolas George george at nsup.org
Tue Oct 28 16:57:35 CET 2014

Le septidi 7 brumaire, an CCXXIII, Binathi a écrit :
>   Branch: refs/heads/master
>   Home:   https://github.com/Binathi/ffmpeg
>   Commit: d83ead999c0343b74d66b58d02c3ef381ac43b69
>       https://github.com/Binathi/ffmpeg/commit/d83ead999c0343b74d66b58d02c3ef381ac43b69
>   Author: Binathi <binti179 at gmail.com>
>   Date:   2014-10-28 (Tue, 28 Oct 2014)
>   Changed paths:
>     M doc/ffserver.conf
>     M ffserver.c
>   Log Message:
>   -----------
>   Forks new process to allow ffserver run in daemon mode

I am sorry, but that it still not correct.

You uploaded a snapshot of the source code to the tree, that makes it
completely distinct from official FFmpeg repository. You need to make a
clone of the official repository and work your patches in a branch started
from the head.

Then you must produce a patch and send it to the mailing list, using git
format-patch or git send-email.

I strongly suggest that just before actually sending the patch, you read it
yourself carefully, and you compare it to patches sent to the mailing list
that are quickly accepted. If your patch is very different from the ones on
the mailing list, there is probably something you need to fix.

In this particular instance, I see that your pull request has "3,894
additions, 4,389 deletions" on ffserver.c: this is way too much for such a
small feature, or for any reasonable feature for that matter. It seems you
lost all the code's indentation somewhere, and the thousands of changes are
mostly that.

You would probably be better of re-starting with a completely new clone of
the official repository (I insist: clone; do not download any source code
using your browser), and then use the -w option of diff to help you import
manually your changes from the first working tree.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141028/04cd4291/attachment.asc>

More information about the ffmpeg-devel mailing list