[FFmpeg-devel] [PATCH 4/6] dv: fix weight table for 2x4x8 transform

[Michael Niedermayer]

On Thu, Oct 30, 2014 at 02:49:30PM +0100, Christophe Gisquet wrote:
> Hi,
> 
> 2014-10-26 19:20 GMT+01:00 Michael Niedermayer <michaelni at gmx.at>:
> > I took the liberty to apply the patch and fix the bug instead of
> > leaving it open until someone succeeds writing a fate test for it
> 
> Hi, I wonder whether this should be reverted for now (and ticket #2970
> reopened at the same time).

The patch fixes decoder artifacts, i dont think we should just revert
it unless it causes artifacts in some other (known to be good) file


> 
> I have been checking how to produce interlaced content through the
> encoder, and the current table produces worse results (PSNR-wise, but
> it was big enough to not bother checking visually).
> 

> I don't know if that's an encoder issue yet or if the decoder table is
> still incorrect.

did you try to decode with a "known to be correct" decoder ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141030/b9164fd6/attachment.asc>