[FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain
jkrause at posteo.de
Tue Sep 2 13:52:24 CEST 2014
Am 02.09.2014 12:40 schrieb Michael Niedermayer:
> On Tue, Sep 02, 2014 at 12:33:26PM +0200, Jörg Krause wrote:
>> Add the feature test macro which is required for building with the
>> musl toolchain.
>> The feature test macro _XOPEN_SOURCE = 600 provides the XSI-compliant
>> version of strerror_r().
> is there a reason why you dont set it from configure ?
> similar to the existing "-D_XOPEN_SOURCE=600" code in configure ?
I followed the recommendation from the GNU C Library Reference Manual,
ch. 1.3.4 Feature Test Macro:
You should define these macros by using ‘#define’ preprocessor
directives at the top of your source code files. These directives must
come before any #include of a system header file. It is best to make
them the very first thing in the file, preceded only by comments. You
could also use the ‘-D’ option to GCC, but it's better if you make the
source files indicate their own meaning in a self-contained way.
Do you prefer to define the macro in configure?
More information about the ffmpeg-devel