[FFmpeg-devel] [PATCH] tests: Download lena.pnm if its missing from the source tree
u at pkh.me
Wed Sep 3 16:50:55 CEST 2014
On Wed, Sep 03, 2014 at 04:47:21PM +0200, Clément Bœsch wrote:
> On Wed, Sep 03, 2014 at 04:38:15PM +0200, Clément Bœsch wrote:
> > On Sun, Aug 31, 2014 at 02:35:40PM +0200, Andreas Cadhalpun wrote:
> > > On 28.08.2014 20:06, Nicolas George wrote:
> > > >Le primidi 11 fructidor, an CCXXII, Andreas Cadhalpun a écrit :
> > > >>I like this colour of the shed. ;)
> > > >> * move lena.pnm to the FATE samples
> > > >> * add e.g. mona_lisa.pnm and duplicate the vsynth2 tests (as vsynth4?)
> > > >>
> > > >>Has someone a problem with this solution?
> > > >
> > > >I find it very good.
> > > >
> > > >Just a small nitpick: does the image have to be 256×256? If not, I suggest
> > > >to make mona_lisa.pnm 256×384 or 192×288, to avoid cropping the original.
> > >
> > > Yes, 256×384 fits better.
> > > Attached is a patch on top of the one removing tests/lena.pnm, adding
> > > tests/mona_lisa.pnm and vsynth4 tests.
> > >
> > > Best regards,
> > > Andreas
> > Duplicate all the tests? Yeah please no, that's a hell to maintain.
> > lena.pnm can be moved to the FATE samples, and replaced in the repo by
> > something else.
> > The question is still by what we replace it. This can be the mona lisa but
> > the reason of the presence of lena.pnm is that it's extremely famous in
> > the image processing world, and so we should replace it with something
> > similar. Typically, mandrill.bmp could be a good candidate:
> > https://encrypted.google.com/search?tbm=isch&q=mandrill.bmp&tbs=imgo:1
> > ...but I don't know the license either.
> But again, as you can see on
> http://eskeptrical.blogspot.com/2012/01/lena.html for example, it is a
> more appropriate image.
Just realized the article content will not really help my argument. Oh
well, I'm out of this. Sorry for the noise.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 473 bytes
Desc: not available
More information about the ffmpeg-devel