[FFmpeg-devel] [PATCH] tests: Download lena.pnm if its missing from the source tree
michaelni at gmx.at
Wed Sep 3 18:06:50 CEST 2014
On Wed, Sep 03, 2014 at 04:38:15PM +0200, Clément Bœsch wrote:
> On Sun, Aug 31, 2014 at 02:35:40PM +0200, Andreas Cadhalpun wrote:
> > On 28.08.2014 20:06, Nicolas George wrote:
> > >Le primidi 11 fructidor, an CCXXII, Andreas Cadhalpun a écrit :
> > >>I like this colour of the shed. ;)
> > >> * move lena.pnm to the FATE samples
> > >> * add e.g. mona_lisa.pnm and duplicate the vsynth2 tests (as vsynth4?)
> > >>
> > >>Has someone a problem with this solution?
> > >
> > >I find it very good.
> > >
> > >Just a small nitpick: does the image have to be 256×256? If not, I suggest
> > >to make mona_lisa.pnm 256×384 or 192×288, to avoid cropping the original.
> > Yes, 256×384 fits better.
> > Attached is a patch on top of the one removing tests/lena.pnm, adding
> > tests/mona_lisa.pnm and vsynth4 tests.
> > Best regards,
> > Andreas
> Duplicate all the tests? Yeah please no, that's a hell to maintain.
iam not sure about this either
what really gives me a bit of a odd feeling is that this is a
while adding more tests is a technical thing. I dont think we should
be discussing that here
> lena.pnm can be moved to the FATE samples, and replaced in the repo by
> something else.
yes, mona lisa is an option
an alternative would be a downscaled one of this:
its public domain according to: https://stallman.org/
either way, we do need some kind of decission on what to do about
the image, and i dont think theres a perfect solution that achives
as it should do no harm and was suggested a few times, ive added
lena.pnm to the fate samples
ive another somewhat related idea, ill post a patch for it in a moment
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 181 bytes
Desc: Digital signature
More information about the ffmpeg-devel