[FFmpeg-devel] [PATCH] vfi/x86/vf_idet: fix incorrect use of paddq
pascal.massimino at gmail.com
Fri Sep 5 09:08:56 CEST 2014
On Thu, Sep 4, 2014 at 3:22 PM, James Darnley <james.darnley at gmail.com>
> paddq is an SSE2 instruction so it cannot be used for MMX.
> This was probably just a typo because the sums are dwords anyway.
> We should have picked this up in review but we didn't...
> libavfilter/x86/vf_idet.asm | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> diff --git a/libavfilter/x86/vf_idet.asm b/libavfilter/x86/vf_idet.asm
> index fb29804..0eb974b 100644
> --- a/libavfilter/x86/vf_idet.asm
> +++ b/libavfilter/x86/vf_idet.asm
> @@ -70,7 +70,7 @@ cglobal idet_filter_line, 4, 5, 0, a, b, c, width, index
> mova m0, m_sum
> psrlq m_sum, 0x20
> - paddq m0, m_sum
> + paddd m0, m_sum
> movd eax, m0
Looks good to me. Sorry for the typo.
More information about the ffmpeg-devel