[FFmpeg-devel] [PATCH] Add input support for DeckLink devices.
rogerdpack2 at gmail.com
Fri Sep 5 16:37:36 CEST 2014
So you tested this in linux and windows? And it works? What is the
advantage of this over dshow, does it work "better" somehow [I know dshow
is deficient in multiple ways, FWIW]. Or was it just to add linux support?
On Mon, Aug 18, 2014 at 12:40 PM, Deti Fliegl <deti at fliegl.de> wrote:
> Rebased commits to have all changes in one patch. Hopefully it's
> complete now.
> On 18.08.14 19:48, Deti Fliegl wrote:
> > On 18.08.14 19:23, Carl Eugen Hoyos wrote:
> >> Deti Fliegl <deti <at> fliegl.de> writes:
> >>> +/* free() is needed for a string returned by the DeckLink SDL. */
> >>> +#undef free
> >> I believe this is not needed anymore but ...
> > removed it - but this has been part of the existing code which I simply
> > moved to a new file.
> >>> + free((void *) tmpDisplayName);
> >> ... please move the comment here.
> > Done.
> >> Is the cast necessary?
> > Yes.
> >>> + av_log(NULL, AV_LOG_ERROR,
> >> Context should not be NULL.
> > Can hardly be done in this file unless you supply avctx as argument in
> > every function only for av_log purposes.
> >>> + av_log(NULL, AV_LOG_INFO, "Found Decklink mode %d x
> >>> %d with rate %.2f%s\n", bmd_width, bmd_height,
> >>> (float)bmd_tb_den/(float)bmd_tb_num,
> >>> (ctx->bmd_field_dominance==bmdLowerFieldFirst ||
> >>> ctx->bmd_field_dominance==bmdUpperFieldFirst)?"(i)":"");
> >> Please split this line.
> > done.
> >> Isn't your patch missing a configure check and
> >> a change to Makefile?
> > Must have missed some files to commit. Fixing patch attached to this
> >> (What is the license of the decklink libraries?)
> > There is no DeckLink library code in my patch. The already existing
> > decklink encoder support covers how to build ffmpeg with the DeckLink
> > Deti
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
More information about the ffmpeg-devel