[FFmpeg-devel] [PATCH] avcodec/hevc_ps: Always initialize backup in decode_vui()

Michael Niedermayer michaelni at gmx.at
Sat Sep 6 21:29:55 CEST 2014


On Sat, Sep 06, 2014 at 01:28:41PM +0200, Christophe Gisquet wrote:
> 2014-09-06 12:40 GMT+02:00 Michael Niedermayer <michaelni at gmx.at>:
> > -    // Backup context in case an alternate header is detected
> > -    if( get_bits_left(gb) >= 66)
> > -        memcpy(&backup, gb, sizeof(backup));
> > +    memcpy(&backup, gb, sizeof(backup));
> 
> I know people consider obvious comments to waste screen space, but I'd
> prefer more than fewer comments on this.
> 

> What about leaving it?

ok


> 
> Otherwise, ok, and sorry for the original buggy code.

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

What does censorship reveal? It reveals fear. -- Julian Assange
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140906/7bdd6159/attachment.asc>


More information about the ffmpeg-devel mailing list