[FFmpeg-devel] suggested patch: avfilter/vf_subtitles: add support for subtitles font scaling

[Clément Bœsch]

On Thu, Sep 11, 2014 at 09:21:03PM +0200, wm4 wrote:
> On Thu, 11 Sep 2014 03:58:07 +0400
> Sergey <sergemp at mail.ru> wrote:
> 
> > Hello.
> > 
> > Recently I used ffmpeg to embed subtitles, and I needed to scale them.
> > 
> > I thought "original_size" option scales subtitles, but it does not.
> > So I wrote a short patch for it to do that (attached)
> > 
> > If that is considered too complex/bad idea I've also attached another patch
> > that adds a "font_scale" option instead.
> > 
> > I hope you like one of these.
> > -- 
> 
> The first patch looks very wrong. You can't just set the font scale to
> something other than 1, because that might break .ass subtitles (though
> it might be ok with other subtitles).
> 
> The second patch (font_scale option) looks acceptable.

In case you go for the second option, please document it in
doc/filters.texi, and add "TODO: bump lavfi micro" to your commit message
so it's not forgotten by the one applying it.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140911/a312f0d3/attachment.asc>