[FFmpeg-devel] [PATCH 2/4] avformat/img2dec: reduce bmppipe probe score

Michael Niedermayer michaelni at gmx.at
Fri Sep 12 18:18:59 CEST 2014


On Fri, Sep 12, 2014 at 10:14:58AM +0200, Benoit Fouet wrote:
> Hi,
> 
> ----- Mail original -----
> > bmp pipe needs the bmp parser which is not bug free and should thus
> > not be favored
> > over the bmp image2 demuxer
> > 
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  libavformat/img2dec.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c
> > index 8bbcddc..9f48c5d 100644
> > --- a/libavformat/img2dec.c
> > +++ b/libavformat/img2dec.c
> > @@ -574,7 +574,7 @@ static int bmp_probe(AVProbeData *p)
> >          return 0;
> >  
> >      if (!AV_RN32(b + 6)) {
> > -        return AVPROBE_SCORE_EXTENSION + 1;
> > +        return AVPROBE_SCORE_EXTENSION - 1; // lower than extension
> > as bmp pipe has bugs
> > 
> 
> No real opinion on this one, do as you prefer...

applied then

it can be reverted if bmp pipe is improved but that may be hard

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140912/a7c7257b/attachment.asc>


More information about the ffmpeg-devel mailing list