[FFmpeg-devel] [PATCH 1/2] alacenc: fix incorrect buffer use

Christophe Gisquet christophe.gisquet at gmail.com
Sat Sep 20 20:23:08 CEST 2014


The issue lies in actually dead code ("for now it's not used").
---
 libavcodec/alacenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/alacenc.c b/libavcodec/alacenc.c
index b9ad899..fd5bf66 100644
--- a/libavcodec/alacenc.c
+++ b/libavcodec/alacenc.c
@@ -444,7 +444,7 @@ static void write_element(AlacEncodeContext *s,
             // TODO: determine when this will actually help. for now it's not used.
             if (prediction_type == 15) {
                 // 2nd pass 1st order filter
-                int32_t *residual = s->predictor_buf[channels];
+                int32_t *residual = s->predictor_buf[i];
                 for (j = s->frame_size - 1; j > 0; j--)
                     residual[j] -= residual[j - 1];
             }
-- 
1.9.2.msysgit.0



More information about the ffmpeg-devel mailing list