[FFmpeg-devel] [PATCH 10/17] avcodec/webvttdec: add some memory checks

Nicolas George george at nsup.org
Sun Sep 21 19:36:19 CEST 2014


Le jour de la Récompense, an CCXXII, Clément Bœsch a écrit :
> Doesn't this need at least a minor bump?

I consider it a bug fix, not an API change. Can you imagine a case where
people would need to check for it?

> Not really; in SAMI at least the buffer is allocated only once, and
> finalized only at the end. This behaviour could be adopted in other
> text subtitles demuxers.

That makes sense, but you still could do it with an extra argument to select
between finalize, clear and nothing.

> This chunk will change later

Ok.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140921/c3fb08a5/attachment.asc>


More information about the ffmpeg-devel mailing list