[FFmpeg-devel] [PATCH]Do not add extradata size to bitmapinfoheader size

Michael Niedermayer michaelni at gmx.at
Sat Sep 27 15:00:25 CEST 2014


On Sat, Sep 27, 2014 at 10:51:25AM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch is one of two patches necessary to fix ticket #1304.
> The MSDN documentation indicates that the palette is not part of the 
> bitmapinfoheader but the bitmapinfoheader is part of the bitmapinfo 
> structure that also contains the palette.
> 
> An alternative is to add the extradata_size except if it is a palette 
> but imo, attached is more correct.
> 
> The second issue to fix ticket #1304 is that a too small frame size 
> is written to the bitmapinfoheader, it is 192x127 for a 189x127 pal8 
> frame. 0 is allowed if the pix_fmt is rawvideo.
> 
> Please comment, Carl Eugen

>  riffenc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> e48c17bcadec1740fd8216c883b943ae7a7642ee  patchbmpextradata.diff

this breaks "make fate" (changing 39 checksums)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140927/e572faf9/attachment.asc>


More information about the ffmpeg-devel mailing list