[FFmpeg-devel] [PATCH] configure: add pkg-config support for libdcadec

James Almer jamrial at gmail.com
Wed Apr 15 19:03:53 CEST 2015


On 15/04/15 2:00 PM, wm4 wrote:
> On Wed, 15 Apr 2015 17:18:58 +0200
> Simon Thelen <ffmpeg-dev at c-14.de> wrote:
> 
>> Signed-off-by: Simon Thelen <ffmpeg-dev at c-14.de>
>> ---
>> Implemented like the check for libx264 without the warn on fallback. Tested on my system with pkg-config.
>>  configure | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 389de92..1d98828 100755
>> --- a/configure
>> +++ b/configure
>> @@ -5012,7 +5012,8 @@ enabled libcelt           && require libcelt celt/celt.h celt_decode -lcelt0 &&
>>                               { check_lib celt/celt.h celt_decoder_create_custom -lcelt0 ||
>>                                 die "ERROR: libcelt must be installed and version must be >= 0.11.0."; }
>>  enabled libcaca           && require_pkg_config caca caca.h caca_create_canvas
>> -enabled libdcadec         && require libdcadec libdcadec/dca_context.h dcadec_context_create -ldcadec
>> +enabled libdcadec         && { use_pkg_config dcadec libdcadec/dca_context.h dcadec_context_create ||
>> +                               { require libdcadec libdcadec/dca_context.h dcadec_context_create -ldcadec; }; }
>>  enabled libfaac           && require2 libfaac "stdint.h faac.h" faacEncGetVersion -lfaac
>>  enabled libfdk_aac        && require libfdk_aac fdk-aac/aacenc_lib.h aacEncOpen -lfdk-aac
>>  flite_libs="-lflite_cmu_time_awb -lflite_cmu_us_awb -lflite_cmu_us_kal -lflite_cmu_us_kal16 -lflite_cmu_us_rms -lflite_cmu_us_slt -lflite_usenglish -lflite_cmulex -lflite"
> 
> Isn't the fallback not needed anymore?

Yeah, the pkg-config check alone is enough.
There's currently no release out using this wrapper, or any distro whatsoever shipping 
the library in question for that matter, so it can be safely removed without being 
considered a change of behavior.


More information about the ffmpeg-devel mailing list