[FFmpeg-devel] [PATCH v4] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution for AAC

[Michael Niedermayer]

On Wed, Apr 15, 2015 at 01:55:28PM -0300, Claudio Freire wrote:
> On Wed, Apr 15, 2015 at 8:18 AM, Rostislav Pehlivanov
> <atomnuker at gmail.com> wrote:
> > @@ -828,9 +882,17 @@ static void search_for_quantizers_twoloop(AVCodecContext *avctx,
> >
> >          fflag = 0;
> >          minscaler = av_clip(minscaler, 60, 255 - SCALE_MAX_DIFF);
> > +
> > +        for (w = 0; w < sce->ics.num_windows; w += sce->ics.group_len[w])
> > +            for (g = 0; g < sce->ics.num_swb; g++)
> > +                if (sce->band_type[w*16+g] == NOISE_BT)
> > +                    sce->sf_idx[w*16+g] = av_clip(noise_sf[w*16+g], minscaler_n, minscaler_n + SCALE_MAX_DIFF);
> > +
> >          for (w = 0; w < sce->ics.num_windows; w += sce->ics.group_len[w]) {
> >              for (g = 0; g < sce->ics.num_swb; g++) {
> >                  int prevsc = sce->sf_idx[w*16+g];
> > +                if (sce->band_type[w*16+g] == NOISE_BT)
> > +                    continue;
> >                  if (dists[w*16+g] > uplims[w*16+g] && sce->sf_idx[w*16+g] > 60) {
> >                      if (find_min_book(maxvals[w*16+g], sce->sf_idx[w*16+g]-1))
> >                          sce->sf_idx[w*16+g]--;
> 
> 
> This is still done at each iteration rather than at the end.
> 
> Still, it will be a correct result nonetheless (it's idempotent now),
> so I believe it can be committed.

commited

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150415/cb851836/attachment.asc>