[FFmpeg-devel] [libav-devel] [PATCH] alsdec: validate time diff index

Thilo Borgmann thilo.borgmann at mail.de
Wed Apr 22 10:59:29 CEST 2015


Am 21.04.15 um 19:35 schrieb Andreas Cadhalpun:
> On 21.04.2015 08:14, Thilo Borgmann wrote:
>> Am 20.04.15 um 23:20 schrieb Andreas Cadhalpun:
>>> On 19.04.2015 22:20, Luca Barbato wrote:
>>>> I'd check that `master` is always between `raw_buffer` and the end of it.
>>>
>>> You mean something like the attached patch?
>>>
>>>> (I'm not sure if `div_blocks` is validated before, same for `offset`)
>>>
>>> That should catch problems in those as well.
>>
>> Have you tested with fate after applying this patch locally?
> 
> Yes, but only on amd64, where fate passes.
> 
> Attached is a new patch, which should work everywhere.

LGTM

-Thilo



More information about the ffmpeg-devel mailing list