[FFmpeg-devel] [PATCH] Using struct for StyleRecords and implementing support for large boxes(>32 bit) for 3gpp timed text

wm4 nfxjfg at googlemail.com
Sun Apr 26 12:29:23 CEST 2015


On Sun, 26 Apr 2015 08:33:34 +0530
Niklesh Lalwani <lalwani1994 at gmail.com> wrote:

> >
> >
> >
> > On Sun, Apr 26, 2015 at 7:05 AM, Carl Eugen Hoyos <cehoyos at ag.or.at>
> > wrote:
> >
> > Niklesh Lalwani <niklesh.lalwani <at> iitb.ac.in> writes:
> >
> >
> >> > +                if ((text_style + i)->face_style_flags
> >
> >
> >> This looks very strange imo...
> >
> >
> What's wrong? I point my structure to the start of the style records, so,
> (text_style + i)->face_style_flags will give me the value of the attribute
> face_style_flags of (i+1)th style record.

We usually write: text_style[i].face_style_flags

It's the same.

> 
> >> > +    long tsmb_size;
> >
> >
> >> int64_t ?
> >
> >
> >>
> My bad. Yes, I intended to use int64_t / double. I will correct it.
> 



More information about the ffmpeg-devel mailing list