[FFmpeg-devel] [PATCH] avfilter: add findandcover filter

Lou Logan lou at lrcd.com
Thu Apr 30 23:11:41 CEST 2015


On Thu, 30 Apr 2015 14:11:20 +0200, Michael Niedermayer wrote:

> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  configure                     |    1 +
>  doc/filters.texi              |   46 +++++
>  libavfilter/Makefile          |    1 +
>  libavfilter/allfilters.c      |    1 +
>  libavfilter/version.h         |    2 +-
>  libavfilter/vf_findandcover.c |  399 +++++++++++++++++++++++++++++++++++++++++
>  6 files changed, 449 insertions(+), 1 deletion(-)
>  create mode 100644 libavfilter/vf_findandcover.c
> 
[...]
> + at item xmin, ymin, xmax, ymax
> +Specifies the recatangle in which to search.

typo: recatangle/rectangle


[...]
> +    { "ymax", "", OFFSET(ymax), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, FLAGS },
> +    { "mode", "set removial mode", OFFSET(mode), AV_OPT_TYPE_INT, {.i64 = MODE_BLUR}, 0, NB_MODES - 1, FLAGS, "mode" },

typo: removial/removal

This concludes my amazingly useful review.


More information about the ffmpeg-devel mailing list