[FFmpeg-devel] [PATCH 2/2] libavformat/dsfdec: Error dsf_read_header fixed.

Ganesh Ajjanagadde gajjanag at mit.edu
Sat Aug 1 01:33:01 CEST 2015


On Fri, Jul 31, 2015 at 7:01 PM, Ihar A. Tumashyk <itumashyk at gmail.com> wrote:
> Sample rate is written "as is" in header . Is *should not* be devined by
> 8. Refer spec.:
> http://dsd-guide.com/sites/default/files/white-
> papers/DSFFileFormatSpec_E.pdf
>
> After this patch ffprobe will corretly show sample rate for DSF files.
>
> Signed-off-by: Ihar A. Tumashyk <itumashyk at gmail.com>
> ---
>  libavformat/dsfdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/dsfdec.c b/libavformat/dsfdec.c
> index ae198b2..3e162ae 100644
> --- a/libavformat/dsfdec.c
> +++ b/libavformat/dsfdec.c
> @@ -105,7 +105,7 @@ static int dsf_read_header(AVFormatContext *s)
>
>      st->codec->codec_type   = AVMEDIA_TYPE_AUDIO;
>      st->codec->channels     = avio_rl32(pb);
> -    st->codec->sample_rate  = avio_rl32(pb) / 8;
> +    st->codec->sample_rate  = avio_rl32(pb);
>
>      switch(avio_rl32(pb)) {
>      case 1: st->codec->codec_id = AV_CODEC_ID_DSD_LSBF_PLANAR; break;

LGTM, thanks for clarifying intent of previous patch.
I am a little puzzled as to why this was never caught till now,
but then again this is quite recent code with very little testing and commits:
git log libavformat/dsfdec.c
shows very few.

> --
> 2.1.4
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


More information about the ffmpeg-devel mailing list