[FFmpeg-devel] [PATCH 1/4] blowfish: add av_blowfish_alloc()

[Reimar Döffinger]

On 31.07.2015, at 19:18, James Almer <jamrial at gmail.com> wrote:
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
> doc/APIchanges       |  3 +++
> libavutil/blowfish.c | 15 +++++++++++++++
> libavutil/blowfish.h | 10 ++++++++++
> libavutil/version.h  |  5 ++++-
> 4 files changed, 32 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/APIchanges b/doc/APIchanges
> index 29e9da9..d222fc6 100644
> --- a/doc/APIchanges
> +++ b/doc/APIchanges
> @@ -15,6 +15,9 @@ libavutil:     2014-08-09
> 
> API changes, most recent first:
> 
> +2015-xx-xx - lavu 54.30.0
> +  xxxxxxx -  Add av_blowfish_alloc().

If the goal is consistency, wouldn't an API like av_hash be the better solution?
And yes, on-stack allocations were desired, even though they make changes to the structs hard...