[FFmpeg-devel] [PATCH 1/4] blowfish: add av_blowfish_alloc()

Nicolas George george at nsup.org
Sat Aug 1 12:15:27 CEST 2015

Le quartidi 14 thermidor, an CCXXIII, Reimar Döffinger a écrit :
> If the goal is consistency, wouldn't an API like av_hash be the better
> solution?

Hear, hear!

(Actually, when reading that discussion for the first time, I had not
noticed it was about ciphers and not hashes, and my first reaction was
"there is an unified API already".)

> And yes, on-stack allocations were desired, even though they make changes
> to the structs hard...

Pointing the obvious: I very much doubt we ever need to change the struct
used just for the implementation of a 30-years-old block cipher.

This should be the guiding question: weight the potential hassle of a change
in the struct versus the practical hassle of heap allocations.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150801/c1b8c86e/attachment.sig>

More information about the ffmpeg-devel mailing list