[FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

[Ronald S. Bultje]

Hi,

On Sun, Aug 2, 2015 at 7:56 PM, James Almer <jamrial at gmail.com> wrote:

> On 02/08/15 5:40 PM, Henrik Gramner wrote:
> > Change ALLOC_STACK to always align the stack before allocating stack
> space for
> > consistency. Previously alignment would occur either before or after
> allocating
> > stack space depending on whether manual alignment was required or not.
> > ---
> >  libavcodec/x86/h264_deblock.asm |  4 +--
> >  libavutil/x86/x86inc.asm        | 62
> ++++++++++++++++++++++++++---------------
>
> Someone with msvc should test if this doesn't break 8ch audio conversion
> when using
> libswresample (libswresample/x86/audio_convert.asm), where
> HAVE_ALIGNED_STACK is also
> (ab)used.
> FATE will not because afaik there are no tests that deal with 8ch audio
> files at all.


Importantly, on 32bit only. Fortunately, I believe swscale also uses this
construct in a few places, as does vp8/9, so a default fate run definitely
is useful.

Ronald