[FFmpeg-devel] [PATCH] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for VP8 functions
Ronald S. Bultje
rsbultje at gmail.com
Tue Aug 4 12:33:48 CEST 2015
On Tue, Aug 4, 2015 at 2:45 AM, Shivraj Patil <Shivraj.Patil at imgtec.com>
> On Mon, Jul 27, 2015 at 6:01 AM, <shivraj.patil at imgtec.com> wrote:
> +++ b/libavcodec/mips/vp8dsp_init_mips.c
> Is there a reason the init code lives in a different file than the
> implementations? It seems to me all symbols could be static if the init
> code lived in the same file as the implementation. This isn't a big deal,
> just wondering.
> Shivraj:- Yes, the files can be merged, we just followed the tradition as
> done by other platforms.
Well, so, I have to explain this for it to make sense. On most platforms,
like x86 and arm, we use raw assembly (in .asm files), where the init code
(for function pointer assignment) is C, so they can't logically live in
same files. On platforms where we use C-ish languages for platform-specific
optimizations (e.g. intrinsics for altivec, or gcc-style inline assembly
for x86), I believe the preference would be to use static functions and
merge init/code in the same file.
More information about the ffmpeg-devel