[FFmpeg-devel] [PATCH 3/3] tests/fate-run: make FATE non-interactive

[Michael Niedermayer]

On Tue, Aug 11, 2015 at 02:53:37PM -0400, Ganesh Ajjanagadde wrote:
> On Tue, Aug 11, 2015 at 11:35 AM, Michael Niedermayer
> <michael at niedermayer.cc> wrote:
> > On Fri, Jul 31, 2015 at 08:39:00AM -0400, Ganesh Ajjanagadde wrote:
> >> FATE is non-interactive; it should not listen to user commands
> >>
> >> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> >> ---
> >>  tests/fate-run.sh | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tests/fate-run.sh b/tests/fate-run.sh
> >> index b88730a..7aa5df2 100755
> >> --- a/tests/fate-run.sh
> >> +++ b/tests/fate-run.sh
> >> @@ -93,7 +93,7 @@ probeframes(){
> >>
> >>  ffmpeg(){
> >>      dec_opts="-hwaccel $hwaccel -threads $threads -thread_type $thread_type"
> >> -    ffmpeg_args="-nostats -cpuflags $cpuflags"
> >> +    ffmpeg_args="-nostdin -nostats -cpuflags $cpuflags"
> >
> > This is not neccessary and its not how FFmpeg is used by the majority
> > of users scripts AFAIK.
> 
> >
> > I dont mind if fate tests "-nostdin" but it also should test the case
> > without "-nostdin" as thats likely how its used most of the time
> 
> What does testing without -nostdin add?
> Can you give a concrete example of where by applying this patch the
> quality/utility
> of ffmpeg's FATE environment is being reduced?

yes

if the terminal trashing prevention logic is broken
then currently i will notice on the next crash in fate (or rather
when the breakage overlaps with what is tested by fate)

but with "nostdin" i would not notice

scripts from users dont use flags that arent strictly needed normally
so they would not use nostdin and would be affected either way

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150811/5034acc2/attachment.sig>