[FFmpeg-devel] [PATCH 2/3] RFC: Should be squashed in the previous patch if OK
gajjanag at mit.edu
Sat Aug 15 01:03:00 CEST 2015
On Fri, Aug 14, 2015 at 6:44 PM, Alexander Strasser <eclipse7 at gmx.net> wrote:
> On 2015-08-14 17:35 -0400, Ganesh Ajjanagadde wrote:
>> On Fri, Aug 14, 2015 at 4:46 PM, Alexander Strasser <eclipse7 at gmx.net> wrote:
>> > Signed-off-by: Alexander Strasser <eclipse7 at gmx.net>
>> > ---
>> > libavutil/parseutils.h | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> > diff --git a/libavutil/parseutils.h b/libavutil/parseutils.h
>> > index b04aa89..cff5123 100644
>> > --- a/libavutil/parseutils.h
>> > +++ b/libavutil/parseutils.h
>> > @@ -112,7 +112,7 @@ int av_parse_color(uint8_t *rgba_color, const char *color_string, int slen,
>> > const char *av_get_known_color_name(int color_idx, const uint8_t **rgb);
>> > /**
>> > - * Parse timestr and return in *timeval a corresponding number of
>> > + * Parse timestr and return in *timeval the corresponding number of
>> > * microseconds.
>> > *
>> > * @param timeval puts here the number of microseconds corresponding
>> > --
>> So how exactly is this different from patch 1/3?
>> Are you sure you emailed the right patch?
> Here I replaced "a" with "the". Saying it returns *a* corresponding
> number of microseconds kind of suggests there is more then one value
> it could choose from.
> Well maybe you could say the original is kind of true for dates
> because of timezones etc... Anyway it is more like a cosmetic
> change if it doesn't resonate with others, I will just drop
> this patch.
I am fine either way. However, I strongly agree that if you want to
change this, it should be squashed.
It is too trivial a commit in my view to stand on its own.
Note that the subtleties of article usage in English are tough even
for native English speakers,
and are glossed over by most of us while reading quickly (which is why
I did not understand the patch initially).
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
More information about the ffmpeg-devel