[FFmpeg-devel] [PATCH 03/13] avfilter: add missing FF_API_AVFILTERBUFFER guards

Michael Niedermayer michael at niedermayer.cc
Sun Aug 16 12:28:42 CEST 2015

On Sun, Aug 16, 2015 at 10:48:57AM +0200, Nicolas George wrote:
> Le nonidi 29 thermidor, an CCXXIII, Michael Niedermayer a écrit :
> > Why is av_buffersink_poll_frame deprecated and removed ?
> Its original semantic of recursing through the graph to count the available
> frames was unsustainable, some filters did return only a very rough
> estimate and some needed very complex code to get an accurate estimate.

i might misremember as i didnt work much on that code recently but
i think it was never intended to give an exact number, just a
value that was guranteed to be available, which would not imply
that there arent more available

an exact number would be unsustainable, yes

> With the current requirement that no frame accumulate within the filter
> graph, it can be replaced by just querying the sink, possibly with the PEEK
> and/or NO_REQUEST flags.

PEEK/NO_REQUEST would tell if the fifo is empty or not
av_buffersink_poll_frame() basically provided the user application
with the number of frames in the fifo (plus what it could figure
out from previous filters) but my concern is about loosing the
detailed information about the fifo


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150816/9ea9241a/attachment.sig>

More information about the ffmpeg-devel mailing list