[FFmpeg-devel] [libav-devel] [PATCH 5/6] Postpone API-incompatible changes until the next bump

Michael Niedermayer michael at niedermayer.cc
Mon Aug 17 16:37:40 CEST 2015


On Mon, Aug 17, 2015 at 07:53:59AM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Aug 17, 2015 at 12:06 AM, Michael Niedermayer <
> michael at niedermayer.cc> wrote:
> 
> > On Sun, Aug 16, 2015 at 10:12:23PM +0200, Andreas Cadhalpun wrote:
> > > Hi,
> > >
> > > On 16.08.2015 19:27, Ronald S. Bultje wrote:
> > > > On Sat, Aug 8, 2015 at 7:37 AM, Andreas Cadhalpun <
> > > > andreas.cadhalpun at googlemail.com> wrote:
> > > >
> > > >> +#define FF_API_VOXWARE           (LIBAVCODEC_VERSION_MAJOR < 58)
> > > >> +#define FF_API_AC_VLC            (LIBAVCODEC_VERSION_MAJOR < 58)
> > > >> +#define FF_API_OLD_MSMPEG4       (LIBAVCODEC_VERSION_MAJOR < 58)
> > > >> +#define FF_API_ARCH_ALPHA        (LIBAVCODEC_VERSION_MAJOR < 58)
> > > >> +#define FF_API_NEG_LINESIZES     (LIBAVCODEC_VERSION_MAJOR < 58)
> > > >> +#define FF_API_ARCH_SH4          (LIBAVCODEC_VERSION_MAJOR < 58)
> > > >> +#define FF_API_ARCH_SPARC        (LIBAVCODEC_VERSION_MAJOR < 58)
> > > >> +#define FF_API_IDCT_XVIDMMX      (LIBAVCODEC_VERSION_MAJOR < 58)
> > > >> +#define FF_API_AVFILTER_OPEN
> > (LIBAVFILTER_VERSION_MAJOR < 7)
> > > >> +#define FF_API_AVFILTER_INIT_FILTER
> >  (LIBAVFILTER_VERSION_MAJOR < 7)
> > > >> +#define FF_API_NOCONST_GET_NAME
> >  (LIBAVFILTER_VERSION_MAJOR < 7)
> > > >> +#define FF_API_OPT_TYPE_METADATA        (LIBAVUTIL_VERSION_MAJOR <
> > 56)
> > >
> > > Removing these now is probably OK, because they seem to be relatively
> > > unused.
> > >
> > > >> +#define FF_API_BUFS_VDPAU        (LIBAVCODEC_VERSION_MAJOR < 58)
> > > >> +#define FF_API_SET_DIMENSIONS    (LIBAVCODEC_VERSION_MAJOR < 58)
> > > >> +#define FF_API_ASPECT_EXTENDED   (LIBAVCODEC_VERSION_MAJOR < 58)
> > > >> +#define FF_API_ERROR_RATE        (LIBAVCODEC_VERSION_MAJOR < 58)
> > > >> +#define FF_API_MB_TYPE           (LIBAVCODEC_VERSION_MAJOR < 58)
> > > >> +#define FF_API_MAX_BFRAMES       (LIBAVCODEC_VERSION_MAJOR < 58)
> > > >> +#define FF_API_INPUT_PRESERVED   (LIBAVCODEC_VERSION_MAJOR < 58)
> > > >> +#define FF_API_NORMALIZE_AQP     (LIBAVCODEC_VERSION_MAJOR < 58)
> > > >> +#define FF_API_GMC               (LIBAVCODEC_VERSION_MAJOR < 58)
> > > >> +#define FF_API_MV0               (LIBAVCODEC_VERSION_MAJOR < 58)
> > > >> +#define FF_API_CODEC_NAME        (LIBAVCODEC_VERSION_MAJOR < 58)
> > > >> +#define FF_API_AFD               (LIBAVCODEC_VERSION_MAJOR < 58)
> >
> > > >> +#define FF_API_OLD_FILTER_OPTS
> > (LIBAVFILTER_VERSION_MAJOR < 7)
> >
> > If thats removed/disabled
> > It will also break user scripts, examples from forum posts and
> > testcases from tickets, this is not just API
> 
> 
> Stackoverflow allows post edits. If you give links to posts to edit, I can
> help edit them.
> 

> To further help users, we can even keep the warning message (without fixing
> it for the user), making it an error, something like:
> 
>             av_log(filter, AV_LOG_ERROR, "This syntax is deprecated. Use "
>                    "'|' to separate the list items.\n");
>             av_log(filter, AV_LOG_ERROR, "Try re-running with args=[%s]\n",
> copy);

i am strongly in favor of this, if support for the old syntax is
removed

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150817/d7903257/attachment.sig>


More information about the ffmpeg-devel mailing list