[FFmpeg-devel] [PATCH] Replace all av_dlog() with av_log(AV_LOG_TRACE).
Ronald S. Bultje
rsbultje at gmail.com
Mon Aug 17 22:56:10 CEST 2015
Hi,
On Mon, Aug 17, 2015 at 2:26 PM, Michael Niedermayer <michael at niedermayer.cc
> wrote:
> On Mon, Aug 17, 2015 at 12:00:21PM -0400, Ronald S. Bultje wrote:
> [...]
> > diff --git a/libavfilter/vsrc_life.c b/libavfilter/vsrc_life.c
> > index 47630ad..a56b163 100644
> > --- a/libavfilter/vsrc_life.c
> > +++ b/libavfilter/vsrc_life.c
> > @@ -334,7 +334,7 @@ static void evolve(AVFilterContext *ctx)
> > if (alive) *newbuf = ALIVE_CELL; // new cell is alive
> > else if (cell) *newbuf = cell - 1; // new cell is dead
> and in the process of mold
> > else *newbuf = 0; // new cell is
> definitely dead
> > - av_dlog(ctx, "i:%d j:%d live_neighbors:%d cell:%d ->
> cell:%d\n", i, j, n, cell, *newbuf);
> > + av_log(ctx, AV_LOG_TRACE, "i:%d j:%d live_neighbors:%d
> cell:%d -> cell:%d\n", i, j, n, cell, *newbuf);
> > newbuf++;
>
> this is called per pixel so ff_tlog() might be better to avoid
> overhead from the call
Oh I hadn't seen that. ff_tlog seems somewhat useless because it doesn't
assure it keeps compiling, but ff_dlog seems pretty useful and fits the
same scope of av_dlog, so I'll use that instead...
Ronald
More information about the ffmpeg-devel
mailing list