[FFmpeg-devel] [PATCH] Replace all av_dlog() with av_log(AV_LOG_TRACE).

[Ronald S. Bultje]

Hi,

On Mon, Aug 17, 2015 at 5:00 PM, Clément Bœsch <u at pkh.me> wrote:

> On Mon, Aug 17, 2015 at 04:56:10PM -0400, Ronald S. Bultje wrote:
> > Hi,
> >
> > On Mon, Aug 17, 2015 at 2:26 PM, Michael Niedermayer
> <michael at niedermayer.cc
> > > wrote:
> >
> > > On Mon, Aug 17, 2015 at 12:00:21PM -0400, Ronald S. Bultje wrote:
> > > [...]
> > > > diff --git a/libavfilter/vsrc_life.c b/libavfilter/vsrc_life.c
> > > > index 47630ad..a56b163 100644
> > > > --- a/libavfilter/vsrc_life.c
> > > > +++ b/libavfilter/vsrc_life.c
> > > > @@ -334,7 +334,7 @@ static void evolve(AVFilterContext *ctx)
> > > >              if (alive)     *newbuf = ALIVE_CELL; // new cell is
> alive
> > > >              else if (cell) *newbuf = cell - 1;   // new cell is dead
> > > and in the process of mold
> > > >              else           *newbuf = 0;          // new cell is
> > > definitely dead
> > > > -            av_dlog(ctx, "i:%d j:%d live_neighbors:%d cell:%d ->
> > > cell:%d\n", i, j, n, cell, *newbuf);
> > > > +            av_log(ctx, AV_LOG_TRACE, "i:%d j:%d live_neighbors:%d
> > > cell:%d -> cell:%d\n", i, j, n, cell, *newbuf);
> > > >              newbuf++;
> > >
> > > this is called per pixel so ff_tlog() might be better to avoid
> > > overhead from the call
> >
> >
> > Oh I hadn't seen that. ff_tlog seems somewhat useless because it doesn't
> > assure it keeps compiling, but ff_dlog seems pretty useful and fits the
> > same scope of av_dlog, so I'll use that instead...
>
> You can't use it outside ouf libavcodec (or its dependencies, which
> libavfilter isn't part of).


I can move it to lavu/internal.h, right? Or is that bad taste?

Ronald