[FFmpeg-devel] [PATCH 13/13] disable deprecation warnings in deprecated code

[Andreas Cadhalpun]

On 22.08.2015 20:40, James Almer wrote:
> On 08/08/15 8:33 AM, Andreas Cadhalpun wrote:
>> diff --git a/libavutil/opt.c b/libavutil/opt.c
>> index 62db1b5..b5df9a3 100644
>> --- a/libavutil/opt.c
>> +++ b/libavutil/opt.c
>> @@ -1178,11 +1178,13 @@ int av_opt_show2(void *obj, void *av_log_obj, int req_flags, int rej_flags)
>>  void av_opt_set_defaults(void *s)
>>  {
>>  #if FF_API_OLD_AVOPTIONS
>> +FF_DISABLE_DEPRECATION_WARNINGS
>>      av_opt_set_defaults2(s, 0, 0);
> 
> av_opt_set_defaults2() deprecation was undone in
> 3285005347b2980fc078d4b5777844070bb6113b, so this (and any other case) are not needed
> anymore.

Yes, I didn't push the unnecessary ones.

> For that matter, this kind of change should probably be mentioned in APIChanges.
> We can't really expect downstream to keep up with deprecations unless we start being
> consistent about it (announcing new deprecations, delays, removal of deprecation
> status, etc).

I agree. In this case, av_opt_set_defaults2 was never mentioned in APIchanges.

Best regards,
Andreas