[FFmpeg-devel] [PATCH 2/4] move the FF_QSCALE_TYPE_* defines to libavutil/internal.h

[Andreas Cadhalpun]

Hi,

On 31.08.2015 14:32, Ronald S. Bultje wrote:
> On Mon, Aug 31, 2015 at 8:09 AM, Andreas Cadhalpun <
> andreas.cadhalpun at googlemail.com> wrote:
>> These defines are used in libavcodec and libavfilter.
>> Since libavfilter only uses them for ff_norm_qscale, we could also move
>> that
>> to libavcodec and call it avpriv_norm_qscale.
>>
>> Do you like this idea better?
>>
> 
> Yes, let's do that (I think that's what we originally had, maybe with a
> different prefix, right?). At least it keeps libavutil clean(er) and
> contains this hack to libavcodec alone. It's not great but I don't see
> anything better, thanks for looking at this.

OK, patch for that attached.

> The larger problem is anyway the qscale part of FF_API_AVFRAME_LAVC, which
>> we need for av_frame_get_qp_table. I don't see an easy solution for that.
> 
> 
> That was supposed to become side-data, we just never changed our code,
> right?

I think so.

> I can look at that today if you want.

That would be great.

> Is there any other upcoming deprecation that fails compile+fate?

There is FF_API_DEBUG_MV, but you know that.

And some of the more recent ones are problematic:
Build failure:
FF_API_MPV_OPT
FF_API_CODED_FRAME
FF_API_MOTION_EST
FF_API_WITHOUT_PREFIX
FF_API_QP_TYPE
FF_API_CRYPTO_CONTEXT

Fate failure:
FF_API_AVCTX_TIMEBASE

Best regards,
Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avcodec-add-qscale.h-for-FF_QSCALE_TYPE_-and-avpriv_.patch
Type: text/x-diff
Size: 7390 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150831/99dc18e7/attachment.patch>