[FFmpeg-devel] [PATCH 0/8] Bunch of CID fixes

Ganesh Ajjanagadde gajjanagadde at gmail.com
Fri Dec 4 15:39:35 CET 2015

Most of these are not terribly important, but are nonetheless bugs that need
to be fixed.

Brief summary given below:
1,2,3,6,7 relate to filter formats memory leaks. This was the outcome of some
more detailed investigation following a back and forth with Paul. Credit should
also go to Michael here since he asked for a more detailed investigation into the
issue when I posted an initial attempt towards fixing these issues.

Note that Paul's remark about leaks in avfilter/af_aformat still remains; outside
the scope of this patchset. Also outside the scope are leaks noted in recently
added filters, and others not detected by Coverity. Maintainers should address
such things (assuming the analysis here is correct).

4,8 are simplistic corrections related to the standard library usage.

5 is a different, unrelated memleak that triggered Coverity, and was hence part
of this work geared mainly towards cleaning up the Coverity scan.

Individual patches tested with valgrind, except for the rtsp one which should
be reasonably clear (with no complicated refcounting business).

Patchset as a whole tested with FATE.

Ganesh Ajjanagadde (8):
  avfilter/vf_overlay: fix memory leaks
  avfilter/vf_alphamerge: fix memory leaks
  avfilter/af_channelmap: fix memory leak
  avformat/movenc-test: correct varargs usage
  avformat/rtsp: free opts dictionary on failure of getnameinfo
  avfilter/show_palette: fix memory leak
  avfilter/af_amix: fix memory leak
  avcodec/dvdsubdec: fix typo in dlog message

 libavcodec/dvdsubdec.c       |  2 +-
 libavfilter/af_amix.c        | 28 +++++++++++++++-------------
 libavfilter/af_channelmap.c  | 10 +++++++++-
 libavfilter/vf_alphamerge.c  | 14 +++++++++++---
 libavfilter/vf_overlay.c     | 32 +++++++++++++++++++++++---------
 libavfilter/vf_showpalette.c | 14 ++++++++++----
 libavformat/movenc-test.c    |  1 +
 libavformat/rtsp.c           |  1 +
 8 files changed, 71 insertions(+), 31 deletions(-)


More information about the ffmpeg-devel mailing list