[FFmpeg-devel] [PATCH] avcodec: avutil: use avutil/thread.h instead of redundant conditional includes

Clément Bœsch u at pkh.me
Mon Dec 7 16:25:28 CET 2015


On Mon, Dec 07, 2015 at 10:22:10AM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Dec 7, 2015 at 10:15 AM, Clément Bœsch <u at pkh.me> wrote:
> 
> > On Mon, Dec 07, 2015 at 04:13:11PM +0100, Nicolas George wrote:
> > > Le septidi 17 frimaire, an CCXXIV, Clement Boesch a écrit :
> > > > From: Clément Bœsch <clement at stupeflix.com>
> > > >
> > > > ---
> > > >  libavcodec/frame_thread_encoder.c |  9 +--------
> > > >  libavcodec/pthread_frame.c        | 10 ++--------
> > > >  libavcodec/utils.c                |  9 +--------
> > > >  libavcodec/vp8.h                  |  9 +--------
> > > >  libavutil/opencl.c                | 10 +---------
> > > >  libavutil/threadmessage.c         | 12 +-----------
> > > >  6 files changed, 7 insertions(+), 52 deletions(-)
> > >
> > > No objection from me.
> > >
> >
> > Will push soon
> >
> > > Nit: "avutil, avcodec:" or "lavu, lavc:" instead of "avutil: avcodec:".
> > >
> >
> > sure.
> >
> > BTW, i think we should decide on av{util,codec,...} vs lav[ufc...] and
> > stick with it. This inconsistency is triggering my mild OCD.
> 
> 
> Hahahahaha :-D.
> 
> Why don't you bofh us and tell us what to do and we'll follow? I nominate
> you to be the review-bully and ensure people follow your rule.
> 

I'm using the av* form for historical reasons, but I'd prefer lav* one if
that was only up to me.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151207/4919d432/attachment.sig>


More information about the ffmpeg-devel mailing list