[FFmpeg-devel] [PATCH 1/2] avcodec/nvenc: Include NVENC SDK header

Timo Rothenpieler timo at rothenpieler.org
Mon Dec 7 19:34:20 CET 2015

> I don't remember if this was discussed when avisynth and other headers
> where included, but what's the advantage of directly including the
> header and burden the FFmpeg sources, rather than asking the user to
> download them in case of need?

The nvenc sdk isn't exactly a common thing that distributions provide.
As distributions can now easily ship ffmpeg with nvenc support, this
propably helps users who now no longer need to build ffmpeg themselves
for nvenc support.

> Also: cygwin fixes should be sent upstream, rather than maintained in
> FFmpeg.

This isn't primarily about cygwin support. The change is just ||
defined(__CYGWIN__) that's added to one #if.
Also, sending patches upstream might take years or could be ignored

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151207/ab4ca67b/attachment.sig>

More information about the ffmpeg-devel mailing list