[FFmpeg-devel] [PATCH] QSV : making three qsv routines public

Hendrik Leppkes h.leppkes at gmail.com
Mon Dec 14 12:35:20 CET 2015


On 14.12.2015 09:57, Sven Dueking wrote:
>
>> >-----Urspr√ľngliche Nachricht-----
>> >Von: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] Im Auftrag
>> >von Hendrik Leppkes
>> >Gesendet: Donnerstag, 10. Dezember 2015 10:19
>> >An: FFmpeg development discussions and patches
>> >Betreff: Re: [FFmpeg-devel] [PATCH] QSV : making three qsv routines
>> >public
>> >
>> >On Thu, Dec 10, 2015 at 10:16 AM, Sven Dueking<sven at nablet.com>  wrote:
>>> > >This patch expose 3 QSV functions as public.
>>> > >This is needed because the VPP needs access to these functions too.
>>> > >
>>> > >Please review.
>>> > >
>> >
>> >public API is not allowed to use config.h, it needs to be config and OS
>> >agnostic.
>> >
>> >- Hendrik
> Updated patch attached, I removed the config.h related stuff and use a void pointer instead.
> (should be ok since VADisplay is a void * pointer)
>
> Please review.

The patch fails to build when libmfx is not available.

>
>
>  From f740857a4bd917d141d1b77a1a2f91438f71fae1 Mon Sep 17 00:00:00 2001
> From: Sven Dueking<sven at nablet.com>
> Date: Thu, 10 Dec 2015 13:06:43 +0000
> Subject: [PATCH] make some internal QSV routines public

A more descriptive title would be nice, maybe like this?
avcodec/qsv: export session management functionality

Full review of the changes postponed until the build failure is resolved.

-- 
Hendrik


More information about the ffmpeg-devel mailing list