[FFmpeg-devel] avfilter/vf_decimate: Check that input parameters match

Michael Niedermayer michaelni at gmx.at
Wed Dec 16 18:53:49 CET 2015


On Wed, Dec 16, 2015 at 03:57:47PM +0100, Nicolas George wrote:
> Le quartidi 24 frimaire, an CCXXIV, Michael Niedermayer a écrit :
> > ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Mon Dec 14 21:18:39 2015 +0100| [30fe3fd52721c8c6566001192cd16be423ffc92b] | committer: Michael Niedermayer
> > 
> > avfilter/vf_decimate: Check that input parameters match
> > 
> > Fixes Ticket4964
> 
> Is it really a fix? The documentation does not state that both inputs need
> to have the same size, and I see no reason for this limitation. Quite the
> contrary, performing expensive treatments (denoising, then comparing) on a
> scaled-down version of the video seem like a good idea.

oops, i misunderstood the intend of the 2nd source ... i based my
understanding on the code and that compared frames between the 2
inputs, in which case different resolutions would have made no
sense.

Hopefully better patchset posted, sorry

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151216/1df7a903/attachment.sig>


More information about the ffmpeg-devel mailing list