[FFmpeg-devel] [libav-devel] [PATCH] opus_silk: fix out of array read in silk_lsf2lpc

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Wed Dec 16 19:35:13 CET 2015


On 16.12.2015 02:02, Michael Niedermayer wrote:
> On Tue, Dec 15, 2015 at 10:41:15PM +0100, Andreas Cadhalpun wrote:
>>  opus_silk.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 253c6f7d87dcadf712840f45dde18f5698b9c1d4  0001-opus_silk-fix-typo-causing-overflow-in-silk_stabiliz.patch
>> From d3b2c24d391d7871b978b3372f0f740730996ded Mon Sep 17 00:00:00 2001
>> From: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
>> Date: Tue, 15 Dec 2015 22:00:31 +0100
>> Subject: [PATCH] opus_silk: fix typo causing overflow in silk_stabilize_lsf
>>
>> Due to this typo max_center can be too large, causing nlsf to be set to
>> too large values, which in turn can cause nlsf[i - 1] + min_delta[i] to
>> overflow to a negative value, which is not allowed for nlsf and can
>> cause an out of bounds read in silk_lsf2lpc.
> 
> this looks nicer then the previous fixes

Indeed, pushed.

Best regards,
Andreas



More information about the ffmpeg-devel mailing list