[FFmpeg-devel] [PATCH] Revert "Merge commit '741b494fa8cd28a7d096349bac183893c236e3f9'"
h.leppkes at gmail.com
Thu Dec 17 14:46:40 CET 2015
On Thu, Dec 17, 2015 at 2:06 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> From: Michael Niedermayer <michael at niedermayer.cc>
> This fixes a regression of the sample from Ticket 2371
> This reverts commit bc66451e5e903698ee0500faf04c1214f3dd157f, reversing
> changes made to 9d1fb9ef313e0fb709ac4c35c7bf00264963fd85.
> libavcodec/h264.h | 8 +++++++
> libavcodec/h264_refs.c | 57 ++++++++++++++++++++++++++---------------------
> libavcodec/h264_slice.c | 17 +++++++++++++-
> 3 files changed, 56 insertions(+), 26 deletions(-)
Reverting big commits to fix one sample and making future merges
harder or impossible seems not like the best option, unless it can be
shown that the entire change is flawed, and not just a small bug.
Otherwise, it should be attempted to fix regressions the usual way -
by fixing things, not reverting.
Once reverted, the change will never come back, we all know that.
At least thats IMHO. You are the maintainer of the H264 decoder, so if
you want to revert it, feel free.
More information about the ffmpeg-devel