[FFmpeg-devel] [PATCH] lavu/libm: change macros to functions

Ronald S. Bultje rsbultje at gmail.com
Sun Dec 27 14:38:37 CET 2015


On Thu, Dec 24, 2015 at 1:32 PM, Ganesh Ajjanagadde <gajjanagadde at gmail.com>

> In the standard library, these are functions. We should match it; there
> is no reason for these to be macros.
> While at it, add some trivial comments for readability and correct an
> incorrect (at standard double precision) M_LN2 constant used in the exp2
> fallback.

For bisect purposes, the M_LN2 change should be a separate patch IMO. I
don't have objections to that one.

As for the rest, I'm not against it, but this stuff is extremely brittle so
please test it extremely carefully on various configs.


More information about the ffmpeg-devel mailing list