[FFmpeg-devel] [PATCH] avcodec/hevc: reduce memory used by the SAO

Michael Niedermayer michaelni at gmx.at
Mon Feb 2 15:31:54 CET 2015


On Mon, Feb 02, 2015 at 02:22:36PM +0100, Christophe Gisquet wrote:
> Hi,
> 
> 2015-02-02 13:32 GMT+01:00 Michael Niedermayer <michaelni at gmx.at>:
> > On Mon, Feb 02, 2015 at 07:41:54AM +0100, Christophe Gisquet wrote:
> > hmm, is there a reason not to take the original commit unchanged ?
> > I was hoping to reduce the difference to openhevc so that we also
> > are able to merge future changes from openhevc with few confilcts
> > but maybe iam missing something
> 
> Because there are alignment requirements in our dsp, and technically,
> adding another buffer (which isn't aligned) while there are already
> perfectly good ones is not the best solution (memory-wise and
> bookkeeping-wise).
> 

> I'd go as far as suggest openhevc to align to this version. But maybe
> they have diverged too much.

iam happy with either openhevc picking this version or us picking
the one from openhevc with minimal changes needed to make it work for
us..
Though in the first case we should pick the openhevc version and
comit our changes in a seperate commit on top so openhevc can
more easily pick the changes we made if they want to.

either way i hope very much that openhevcs and our implementation
could stay similar as divergence would mean duplicated maintaince
effort and both projects would have to do extra work in picking
changes from the other


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150202/3cbf9a60/attachment.asc>


More information about the ffmpeg-devel mailing list