[FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist
Reimar.Doeffinger at gmx.de
Tue Feb 3 21:34:30 CET 2015
On Tue, Feb 03, 2015 at 02:57:56PM +0100, wm4 wrote:
> On Tue, 3 Feb 2015 01:10:11 +0100
> Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:
> > On Mon, Feb 02, 2015 at 06:49:11PM -0500, Ben Boeckel wrote:
> > > FLAC doesn't really support IDv3 tags, so warn if they are found at all.
> > > If vorbis tags are found, toss out the IDv3 tags. They are kept if
> > > vorbis tags aren't found to at least have something there.
> > I'm not really convinced this makes sense.
> > There are thousands of programs that can edit IDv3 tags, but
> > comparatively few that can handle vorbis tags.
> > If both exist, why should the Vorbis tags be more likely to
> > be correct?
> > The warnings I sure agree with though.
> Any suggestions how we should handle mp3? mp3 can have the following
> tags (from what I've found out so far): id3v1, id3v2, ape, lyrics.
> Currently, only the id3 ones are read (v1 is dropped if v2 exists).
But in principle and ideally I think you'd start by reading them all,
and then merge those that are non-contradictory (e.g. because
they have the same value or because some field exits only in one).
Of the conflicting ones you can assign a score, for which
you could for example see how much data is set in each of these.
Also the ones that are most popular and easiest to add (I suspect
id3v1/id3v2) should have some priority.
In addition it would be possible to just export the raw
data in conflicting case, e.g. have
Author = "best guess"
ID3v2/Author = "best guess"
ape/Author = "we ignored this one"
But honestly I'm kind of the wrong person to ask because I
never tagged any of my files, file names are plenty good
enough for me...
More information about the ffmpeg-devel