[FFmpeg-devel] [PATCH] avcodec/hevc: reduce memory used by the SAO
michaelni at gmx.at
Wed Feb 4 02:05:19 CET 2015
On Mon, Feb 02, 2015 at 04:02:41PM +0100, Michael Niedermayer wrote:
> On Mon, Feb 02, 2015 at 03:31:54PM +0100, Michael Niedermayer wrote:
> > On Mon, Feb 02, 2015 at 02:22:36PM +0100, Christophe Gisquet wrote:
> > > Hi,
> > >
> > > 2015-02-02 13:32 GMT+01:00 Michael Niedermayer <michaelni at gmx.at>:
> > > > On Mon, Feb 02, 2015 at 07:41:54AM +0100, Christophe Gisquet wrote:
> > > > hmm, is there a reason not to take the original commit unchanged ?
> > > > I was hoping to reduce the difference to openhevc so that we also
> > > > are able to merge future changes from openhevc with few confilcts
> > > > but maybe iam missing something
> > >
> > > Because there are alignment requirements in our dsp, and technically,
> > > adding another buffer (which isn't aligned) while there are already
> > > perfectly good ones is not the best solution (memory-wise and
> > > bookkeeping-wise).
> > >
> > > I'd go as far as suggest openhevc to align to this version. But maybe
> > > they have diverged too much.
> > iam happy with either openhevc picking this version or us picking
> > the one from openhevc with minimal changes needed to make it work for
> > us..
> > Though in the first case we should pick the openhevc version and
> > comit our changes in a seperate commit on top so openhevc can
> > more easily pick the changes we made if they want to.
> For reference attached the difference between the 2 implementations
> that is diff between this version and the one cherry picked from
> openhevc (actually cherry picked yesterday and rebased to HEAD)
applied the cherry picked code and the update
Thanks to all
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 181 bytes
Desc: Digital signature
More information about the ffmpeg-devel