[FFmpeg-devel] [PATCH 7/7] x86: hevc: remove a parameter to WP internals

[James Almer]

On 06/02/15 6:14 AM, Christophe Gisquet wrote:
> 2015-02-05 20:20 GMT+01:00 Christophe Gisquet <christophe.gisquet at gmail.com>:
>> > -cglobal hevc_put_hevc_bi_w%1_%2, 5, 7, 10, dst, dststride, src, srcstride, src2, height, denom, wx0, wx1, ox0, ox1
>> > -    mov              r6d, denomm
>> > +cglobal hevc_put_hevc_bi_w%1_%2, 4, 5, 10, dst, dststride, src, src2, height, denom, wx0, wx1, ox0, ox1
>> > +    mov              r5d, denomm
> This is wrong, that should be "4, 6". Strange that it doesn't cause
> issues on win64 (linux x86_64 has the 6 first parameters through gprs
> anyway).

"mov r5d, denomm" is loading it on Win64. It's also a superfluous instruction on
UNIX64, where it translates to "mov r5d, r5d".
At least if i'm reading this right.