[FFmpeg-devel] [PATCH] x86/hevc_sao: fix loading of RIP address

James Almer jamrial at gmail.com
Fri Feb 6 19:09:46 CET 2015


On 06/02/15 2:10 PM, Christophe Gisquet wrote:
> The new common loading block could almost be abstracted in a single
> macro (with the stride as parameter).
> 
> Something like:
> %macro LOAD_EO_ARGS 1
> %define tmp2q heightq
> %if WIN64
>     movsxd           eoq, dword r4m
> %else
>     movsxd           eoq, eod
> %endif
>     lea            tmp2q, [pb_eo]
>     movsx      a_strideq, byte [tmp2q+eoq*4+1]
>     movsx      b_strideq, byte [tmp2q+eoq*4+3]
>     imul       a_strideq, %1
>     imul       b_strideq, %1
>     movsx           tmpq, byte [tmp2q+eoq*4]
>     add        a_strideq, tmpq
>     movsx           tmpq, byte [tmp2q+eoq*4+2]
>     add        b_strideq, tmpq
>     mov          heightd, r6m
> %endmacro
> 
> (macro provided as example because it's probably clearer :D but not tested )

I'll leave that for when i write the x86_32 version of sao_edge_filter_16, so 
the macro handles both arches.

Patch applied, thanks.


More information about the ffmpeg-devel mailing list