[FFmpeg-devel] [PATCH 7/7] atrac3plus: Prevent array out-of-bounds

Michael Niedermayer michaelni at gmx.at
Sat Feb 7 04:44:11 CET 2015


On Fri, Feb 06, 2015 at 07:32:56AM +0000, Timothy Gu wrote:
> On Thu Feb 05 2015 at 11:07:01 PM Timothy Gu <timothygu99 at gmail.com> wrote:
> 
> > (num_quant_units - 1) is later used as an index to atrac3p_qu_to_subband,
> > which only has 32 elements (i.e. maximum of num_quant_units is 32).
> > ---
> >  libavcodec/atrac3plus.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> 
> Note that this doesn't actually fix any problem else than a GCC warning.

when i read the commit message it sounded like it fixes a serious
bug ...
also the exact warning which is fixed could be mentioned in the
commit message

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150207/00312d04/attachment.asc>


More information about the ffmpeg-devel mailing list