[FFmpeg-devel] [PATCH] avformat: Add simple ACLR atom reading to set the color range
kevin.j.wheatley at gmail.com
Wed Feb 18 10:40:24 CET 2015
So reading through the comments in this thread, it looks to me like
some of the problems come from the use of the mov_read_extradata()
function, which has more logic than the name implies, in particular it
will successfully return even if it did not read the atom into the
extradata, so if i just directly read the atom, what will break? I
could do the ugly thing of reading it and then filling the extradata
(or modify the reading function to better communicate to the callers
if the data was read correctly).
The atom could also not be in the extradata but does it have to be?
The movenc.c writer of the atom doesn't always use the extradata - for
DNxHD relies on the colour_range of the track's encoder directly and
doesn't appear to write the extradata (calls mov_write_avid_tag()),
for other codecs it uses mov_write_extradata_tag() (for
AV_CODEC_ID_AVU and AV_CODEC_ID_SVQ3).
This suggests that for DNxHD I don't need it in the extradata to
preserve behaviour, or am I missing something in the code (something
in the use as a library for instance)?
More information about the ffmpeg-devel