[FFmpeg-devel] [PATCH]Simplify mlp_filter_channel_x86()

Hendrik Leppkes h.leppkes at gmail.com
Thu Feb 19 17:09:43 CET 2015


On Thu, Feb 19, 2015 at 4:25 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Hi!
>
> Attached patch by Francisco Blas Izquierdo Riera fixes a compilation
> error in mlpdsp_init.c with -fstack-check and some gcc compilers (I
> reproduced the issue with gcc 4.7.3) by simplifying the code.
> I ran some benchmarks with a very large thd file, 'time' confirms
> the results of '-benchmark'.

Please benchmark ASM changes using STAR/STOP_TIMER macros.
Looking at the code, the change introduces one extra instruction in
x64, and is identical in x86, so I don't really see how it can be
faster?

- Hendrik


More information about the ffmpeg-devel mailing list