[FFmpeg-devel] [libav-devel] [PATCH 1/4] avcodec/a64multienc: use av_frame_ref instead of copying the frame

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Sun Feb 22 23:40:14 CET 2015


On 22.02.2015 23:23, Luca Barbato wrote:
> On 22/02/15 21:56, Andreas Cadhalpun wrote:
>> using the a64multienc encoder currently results in a crash due to a
>> double free.
>> This seems to be broken since [1].
>
> I would expect that an unref would be needed somewhere, do we have a
> fate test for it?

The unref 'av_frame_free(&avctx->coded_frame)' was already added as part 
of commit 13e9cc9.
This is exactly what causes the crash. I doubt that there is a fate test 
for this, because that would have revealed the crash. For testing 
purposes you can use:
avconv -y -i ./tests/reference.pnm -c:v a64multi -f avi /dev/null

Best regards,
Andreas


More information about the ffmpeg-devel mailing list