[FFmpeg-devel] [PATCH] Socket options for librtmp

[Michael Niedermayer]

On Wed, Feb 11, 2015 at 07:33:43PM -0600, Cary Tetrick wrote:
> This reimplements a change authored by Brian Brice <bbrice at gmail.com>
> 2015-01-19
> "librtmp: Allow changing the socket send buffer size"
> (Brian is aware of this change).
> also negates change by Michael Niedermayer <michaelni at gmx.at>  2015-01-23
> 10:45:35
> "avformat/librtmp: Fix build with --disable-network --enable-librtmp"
> because it is no longer necessary.
> 
> The reason for this is that the socket settings changes need to be made in
> librtmp
> internally because:
>   1. librtmp may attemp a new socket connection internally.
>      in that case, it would not get the buffer settings.
>   2. if using the tee muxer to send to more than one destination, the
> arguments
>      can't be passed through the flv muxer. passing them as key-value
> paires in
>   the manner already supported in librtmp works for that use case.
> 
> A patch has been sent to the librtmp mailing list rtmpdump at mplayerhq.hu
> with the title "subject: librtmp arguments added for socket buffer size".
> 

> *This* patch is dependent on the one above, and should be applied after it
> appears in the git://git.ffmpeg.org/rtmpdump repository.

please ping this thread when this happens

about the patch itself

IIUC a user using old rtmpdump with new ffmpeg would loose the
rtmp_buffer_size option.
Would it make sense to support the old setsockopt() code for this
case ?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150224/2bee4336/attachment.asc>